lint: lpc1768/msp430: remove arith ops on void ptrs #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N8Fear
added
Type: cleanup
|
|
|
Seems to make sense: should I also change this for other cpus (like the cortex ones)? |
|
Yes, would make sense to fix this in one go. |
N8Fear
force-pushed
the
void_ptr_arith
branch
from
a4b9566 to
9933dd0
Compare
|
Changed original commit to use |
|
Thanks! ACK. |
Kijewski
added a commit
that referenced
this pull request
Sep 14, 2014
lint: lpc1768/msp430: remove arith ops on void ptrs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup: cppcheck found arithmetic operations on void pointers which can result in undefined behaviour.
This patch fixes it by casting it to the appropriate type (which follows the same logic as i.e. for the cortex-mX or the atmega_common equivalents).