Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/net/gnrc/netif: Make aac_mode a flag field #16596

Merged
merged 2 commits into from
Jun 30, 2021
Merged

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Jun 29, 2021

Contribution description

This PR is another spin-off from #16228. Its changes let the the aac_mode field of gnrc_netif_ipv6_t be treated as flag field.
The members of the net_gnrc_netif_aac enum are updated accordingly. This way, it is possible for a net interface to use (for instance) both SLAAC and DHCPv6 for auto-adress configuration.

Testing procedure

As this is curently more or less a refactoring, you can use the existing gnrc and unit tests should which should still be passing.

Issues/PRs references

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 29, 2021
@JKRhb
Copy link
Member Author

JKRhb commented Jun 29, 2021

Hmm, one test has failed because of unsufficient ROM (4 bytes overflow). Should the board (stm32mp157c-dk2) be added to the BOARD_INSUFFICIENT_MEMORY list or is there maybe a way to fix this?

@benpicco
Copy link
Contributor

I'd say just add it to the list - if it's this tight it's not worth the trouble.
By how much does the ROM consumption increase compared to master? I can't imagine it to be more than a handful of bytes.

@JKRhb
Copy link
Member Author

JKRhb commented Jun 29, 2021

I'd say just add it to the list - if it's this tight it's not worth the trouble.

Will do :)

By how much does the ROM consumption increase compared to master? I can't imagine it to be more than a handful of bytes.

If I am not mistaken, it should be 8 bytes (before, after). So pretty close :/

@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Jun 29, 2021
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - @miri64 any objections?

@miri64
Copy link
Member

miri64 commented Jun 30, 2021

Nope, was my proposal after all :-), let's gooooo.

@miri64 miri64 merged commit c5a1012 into RIOT-OS:master Jun 30, 2021
@JKRhb JKRhb deleted the aac-flags branch June 30, 2021 11:30
@MrKevinWeiss MrKevinWeiss added this to the Release 2021.07 milestone Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants