Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-actions: release-tests: do not run linters for release tests [backport 2021.04] #16380

Merged
merged 1 commit into from
Apr 23, 2021
Merged

gh-actions: release-tests: do not run linters for release tests [backport 2021.04] #16380

merged 1 commit into from
Apr 23, 2021

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Apr 23, 2021

Backport of #16379

Contribution description

The release tests are marked as failing currenty since there is a bug in pylint (or one of its libraries). There is not much sense to run the linter for the release tests on the test scripts, as this is already done in the CI of the release tests. As such, we only need to run the test environment of tox, which executes the release tests.

Testing procedure

I'll run the workflow in my fork, just to see if everything works (to shorten the runtime a REMOVE ME commit is included).

Issues/PRs references

See RIOT-OS/Release-Specs#213 (comment)

@miri64 miri64 added Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Process: release cycle Integration Process: The PR is connected to the release cycle (e.g. release notes) Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Apr 23, 2021
@miri64 miri64 requested a review from kaspar030 April 23, 2021 09:05
@miri64 miri64 mentioned this pull request Apr 23, 2021
Merged
kaspar030
kaspar030 approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@miri64 miri64 merged commit 4fafe5d into RIOT-OS:2021.04-branch Apr 23, 2021
@miri64 miri64 deleted the backport/2021.04/gh-actions/fix/remove-linters branch April 23, 2021 09:09
@kaspar030 kaspar030 added this to the Release 2021.04 milestone Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

Assignees
No one assigned
Labels
Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Process: release cycle Integration Process: The PR is connected to the release cycle (e.g. release notes) Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2021.04
Development

Successfully merging this pull request may close these issues.
2 participants
@miri64 @kaspar030