cpu/stm32f1: spi_transfer_bytes proper counting. #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transferred bytes were being counted more than once because of a += when calling spi_transfer_byte(). This patch should also handle errors from spi_transfer_byte() better since it is now possible to detect errors _after_ the first byte has been successfully sent. Signed-off-by: Joakim Gebart <joakim@gebart.se>
|
ACK for the logic. |
| @@ -128,7 +128,7 @@ int spi_transfer_bytes(spi_t dev, char *out, char *in, unsigned int length) | |||
| if (out != NULL) { | |||
| DEBUG("out*: %p out: %x length: %x\n", out, *out, length); | |||
| while (length--) { | |||
| ret += spi_transfer_byte(dev, *(out)++, 0); | |||
| ret = spi_transfer_byte(dev, *(out)++, 0); | |||
There was a problem hiding this comment.
I think you can reduce the scope of ret while you're here.
I.e.: make the delacration local to the while loops.
|
Tested, works. |
Reduced scope to inside the while loop as per comments in RIOT-OS#1630 Signed-off-by: Joakim Gebart <joakim@gebart.se>
|
I reduced the scope to define ret inside the while loop. |
|
ACK & go |
LudwigKnuepfer
added a commit
that referenced
this pull request
Sep 3, 2014
cpu/stm32f1: spi_transfer_bytes proper counting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transferred bytes were being counted more than once because of a +=
when calling spi_transfer_byte().
This patch should also handle errors from spi_transfer_byte() better
since it is now possible to detect errors after the first byte has
been successfully sent.
I do not have a board to test on so I would need someone else to verify that this is correct.