Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/msbiot: fix param for MPU9150 #16285

Merged
merged 1 commit into from
Apr 7, 2021
Merged

boards/msbiot: fix param for MPU9150 #16285

merged 1 commit into from
Apr 7, 2021

Conversation

maribu
Copy link
Member

@maribu maribu commented Apr 7, 2021

Contribution description

When the driver for the mpu9150 has been renamed to mpu9x50, the
corresponding macro in the MSB-IoT board was forgotten to be renamed
as well. This fixes the issue.

Testing procedure

With master:

> [auto_init_saul] error initializing mpu9x50 #0
main(): This is RIOT! (Version: 2021.04-devel-1223-g9eac73-sys/Makefile.dep)

This PR:

main(): This is RIOT! (Version: 2021.04-devel-1223-g9eac73-sys/Makefile.dep)
Welcome to RIOT!
> saul
ID	Class		Name
#0	ACT_SWITCH	red LED
#1	ACT_SWITCH	yellow LED
#2	ACT_SWITCH	green LED
#3	SENSE_BTN	left button
#4	SENSE_BTN	right button
#5	SENSE_ACCEL	mpu9x50
#6	SENSE_GYRO	mpu9x50
#7	SENSE_MAG	mpu9x50
> saul read 5
Reading from #5 (mpu9x50|SENSE_ACCEL)
Data:	[0]         203 mg
	[1]         -12 mg
	[2]         968 mg
> saul read 6
Reading from #6 (mpu9x50|SENSE_GYRO)
Data:	[0]         0.0 dps
	[1]         0.2 dps
	[2]         0.0 dps
> saul read 7
Reading from #7 (mpu9x50|SENSE_MAG)
Data:	[0]       -0.15 Gs
	[1]       -0.06 Gs
	[2]        0.72 Gs

Issues/PRs references

Broken since #12103

@maribu
boards/msbiot: fix param for MPU9150
9c77cd8 
When the driver for the mpu9150 has been renamed to mpu9x50, the
corresponding macro in the MSB-IoT board was forgotten to be renamed
as well. This fixes the issue.
@maribu maribu added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 7, 2021
@kaspar030 kaspar030 added the Area: drivers Area: Device drivers label Apr 7, 2021
kaspar030
kaspar030 approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@maribu maribu merged commit 6fe7164 into RIOT-OS:master Apr 7, 2021
@maribu
Copy link
Member Author

maribu commented Apr 7, 2021

Thanks :-)

@maribu maribu deleted the boards/msbiot branch April 7, 2021 14:56
@kaspar030 kaspar030 added this to the Release 2021.04 milestone Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2021.04
Development

Successfully merging this pull request may close these issues.
2 participants
@maribu @kaspar030