posix: minor pthread_barrier clean up #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LudwigOrtmann, @authmillenon, wanna merge something? :) |
|
I do not feel this is in my zone of competence ;-) |
|
Sorry, I'm overly busy atm. Assign me if you want me to take a look when I'm free again. |
|
Sorry I didn't realized I was assigned. I will have a look this afternoon. |
| } | ||
| barrier->next = NULL; | ||
| barrier->count = count; | ||
| } | ||
|
|
||
| mutex_unlock(&barrier->mutex); | ||
|
|
||
| if (switch_prio != -1) { | ||
| sched_switch(switch_prio); |
There was a problem hiding this comment.
Ok, I don't get it, why this thread should yield() here?
There was a problem hiding this comment.
When a thread with a higher priority waited on this barrier, then we need to schedule that one. Always if a thread with a higher priority gets un-blocked the current thread needs to yield.
There was a problem hiding this comment.
Ah ok, thx for the explanation.
|
ACK. |
Kijewski
added a commit
that referenced
this pull request
Aug 15, 2014
…ranch-issue-198 posix: minor pthread_barrier clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This are the first two commits of #1307.
pthread_barrier_wait() needs to yield if it woke up a thread with a higher priority, and the Makefile of the accompanying test is cluttered.