Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mtd/*: drop .write() if .write_page() is implemented #15380

Merged
merged 11 commits into from
Dec 13, 2023
Merged

mtd/*: drop .write() if .write_page() is implemented #15380

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2235dc2
cpu/esp_common: flash: drop .write()
benpicco Nov 4, 2020
26aba7b
drivers/at25xxx: drop .write()
benpicco Nov 4, 2020
ea105d3
drivers/mtd_spi_nor: drop .write()
benpicco Nov 4, 2020
ba17c14
drivers/mtd_sdcard: drop .write()
benpicco Nov 4, 2020
c664612
native/mtd: drop .write()
benpicco Nov 4, 2020
d525807
unittests/tests-mtd: expect mtd_write() to always succeed
benpicco Nov 4, 2020
3b489cf
tests/mtd_mapper: drop .write() function
benpicco Feb 28, 2023
6c28a7d
drivers/mtd_mapper: drop .write() function
benpicco Feb 28, 2023
cf123f9
drivers/mtd_emulated: drop .write() function
benpicco Dec 13, 2023
431afea
drivers/mtd_sdmmc: drop .write() function
benpicco Dec 13, 2023
9855b02
mtd: drop .write() function
benpicco Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
unittests/tests-mtd: expect mtd_write() to always succeed 
The MTD layer now takes care of splitting up writes, so it
should always work (as long as the destination address is
within the memory region)
  • Loading branch information
@benpicco
benpicco committed Dec 13, 2023
commit d525807598971823a8a3626b1ae5505e4fbb2910
6 changes: 3 additions & 3 deletions tests/unittests/tests-mtd/tests-mtd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ static void test_mtd_write_read(void)
uint8_t buf_page[page_size + 1];
memset(buf_page, 1, sizeof(buf_page));
ret = mtd_write(dev, buf_page, 0, sizeof(buf_page));
TEST_ASSERT_EQUAL_INT(-EOVERFLOW, ret);
TEST_ASSERT_EQUAL_INT(0, ret);

/* Read more than one page */
ret = mtd_erase(dev, 0, dev->page_size * dev->pages_per_sector);
Expand All @@ -163,9 +163,9 @@ static void test_mtd_write_read(void)

/* pages overlap write */
ret = mtd_write(dev, buf, dev->page_size - (sizeof(buf) / 2), sizeof(buf));
TEST_ASSERT_EQUAL_INT(-EOVERFLOW, ret);
TEST_ASSERT_EQUAL_INT(0, ret);
ret = mtd_write(dev, buf_page, 1, sizeof(buf_page) - 1);
TEST_ASSERT_EQUAL_INT(-EOVERFLOW, ret);
TEST_ASSERT_EQUAL_INT(0, ret);
}

#ifdef MTD_0
Expand Down