cpu/sam0_common: flashpage: attempts at bugfixing #14932
+81
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This 'fixes' what I thought would be the cause for #14929
But this just happens to push the issue away temporariely.
If you replace the interrupt based
wait_for_cmd()
with a pollingor use a different C library or compiler, the bug is back again.
Testing procedure
Flash
tests/mtd_flashpage
onsame54-xpro
.The test will now succeed.
But this is a fluke: try again with
PICOLIBC=1
and it will again fail.(The test would succeed on
master
withPICOLIBC=1
, but fail with newlib. The C library is entirely unrelated to the test.)Issues/PRs references
attempts to fix #14929 (but no sucess so far)