You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ports the weird constructs in tests/lwip to our new test framework riotctrl. While I'm quite happy about the current state, I think there are some things that could be done better and more generalized. This is why I marked it as a PoC. I think this test is just perfect to show the current short-comings of riotctrl:
Getting an IP address is a bit cumbersome
There is no way currently to define a specific board or if the two boards can communicate. The first I circumvented by incrementing the number in the predefined PORT variable (when PORT2 is not defined), the latter by just allowing boards of the same type.
Testing procedure
Run make -C tests/lwip -j flash test. It should succeed. To date, I only tested IPv6 support on native.
There is no way currently to define a specific board or if the two boards can communicate. The first I circumvented by incrementing the number in the predefined PORT variable (when PORT2 is not defined), the latter by just allowing boards of the same type.
There is no way currently to define a specific board or if the two boards can communicate. The first I circumvented by incrementing the number in the predefined PORT variable (when PORT2 is not defined), the latter by just allowing boards of the same type.
What do you mean by a specific BOARD?
For the two nodes required for the test, BOARD needs to be the same for both nodes.
There is no way currently to define a specific board or if the two boards can communicate. The first I circumvented by incrementing the number in the predefined PORT variable (when PORT2 is not defined), the latter by just allowing boards of the same type.
What do you mean by a specific BOARD?
For the two nodes required for the test, BOARD needs to be the same for both nodes.
Well, automatic tests in tests/ are still meant to be run on only one BOARD, handling multiple BOARDs from a build system point of view is an issue/subject on itself.
Well, automatic tests in tests/ are still meant to be run on only one BOARD, handling multiple BOARDs from a build system point of view is an issue/subject on itself.
The test is not run in the automatic tests anyway at the moment ;-).
Area: networkArea: NetworkingArea: pkgArea: External package portsArea: testsArea: tests and testing frameworkState: demonstratorState: This PR (loosely) demonstrates a concept and is not necessarily meant to be merged.Type: cleanupThe issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
miri64
added
Area: network
Contribution description
This ports the weird constructs in
tests/lwipto our new test frameworkriotctrl. While I'm quite happy about the current state, I think there are some things that could be done better and more generalized. This is why I marked it as a PoC. I think this test is just perfect to show the current short-comings ofriotctrl:PORTvariable (whenPORT2is not defined), the latter by just allowing boards of the same type.Testing procedure
Run
make -C tests/lwip -j flash test. It should succeed. To date, I only tested IPv6 support onnative.Issues/PRs references
None