Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/mips32r2_common: include newlib_syscalls_mips_uhi in Makefile.dep #14344

Merged
merged 1 commit into from
Jun 24, 2020
Merged

cpu/mips32r2_common: include newlib_syscalls_mips_uhi in Makefile.dep #14344

merged 1 commit into from
Jun 24, 2020

Conversation

fjmolinas
Copy link
Contributor

Contribution description

Currently the inclusion of newlib_syscalls_mips_uhi depends on a flag set in Makefile.include, this needs to be addressed for #9913. This PR does that.

Testing procedure

for board in 6lowpan-clicker pic32-wifire; do BOARD=${board} make -C examples/hello-world/ info-debug-variable-LINKFLAGS info-debug-variable-CFLAGS info-debug-variable-USEMODULE --no-print-directory > pr.txt; git checkout upstream/master; BOARD=${board} make -C examples/hello-world/ info-debug-variable-LINKFLAGS info-debug-variable-CFLAGS info-debug-variable-USEMODULE --no-print-directory > master.txt; diff pr.txt master.txt; done
#no diff

Issues/PRs references

#9913

@fjmolinas fjmolinas added Area: build system Area: Build system Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 24, 2020
@fjmolinas fjmolinas requested a review from kaspar030 as a code owner June 24, 2020 13:30
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Jun 24, 2020
@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Jun 24, 2020
@fjmolinas
Copy link
Contributor Author

@leandrolanzieri all green!

leandrolanzieri
leandrolanzieri approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the related Makefile variables (CFLAGS, LINKFLAGS and USEMODULE) and everything stays the same. ACK.

@leandrolanzieri leandrolanzieri merged commit 75f487d into RIOT-OS:master Jun 24, 2020
@fjmolinas
Copy link
Contributor Author

Thanks for the quick review!

@fjmolinas fjmolinas deleted the pr_mips_uhi_dep branch June 24, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@aabadie aabadie Awaiting requested review from aabadie

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees
No one assigned
Labels
Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
2 participants
@fjmolinas @leandrolanzieri