Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/kinetis: Move dependencies to Makefile.dep #14111

Merged
merged 1 commit into from
May 26, 2020
Merged

cpu/kinetis: Move dependencies to Makefile.dep #14111

merged 1 commit into from
May 26, 2020

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

This moves dependencies of kinetis to its Makefile.dep, and uses the provided features instead of the model to load the modules.

Testing procedure

  • All kinetis-based boards should still use the same modules.
  • As we still do not have a board which uses an EA series CPU, check that periph_ics is used when setting CPU_MODEL=s9keaz128aclh48.

Issues/PRs references

Part of #9913

@leandrolanzieri leandrolanzieri added Area: build system Area: Build system Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: cpu Area: CPU/MCU ports labels May 20, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone May 20, 2020
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 20, 2020
@PeterKietzmann PeterKietzmann self-requested a review May 26, 2020 07:40
@PeterKietzmann
Copy link
Member

Tested with:

  • BOARD=pba-d-01-kw2x make -C examples/hello-world/ info-modules
  • BOARD=pba-d-01-kw2x make CPU_MODEL=s9keaz128aclh48 -C examples/hello-world/ info-modules
master 
auto_init
board
core
core_init
core_msg
core_panic
cortexm_common
cortexm_common_periph
cpu
newlib
newlib_nano
newlib_syscalls_default
periph
periph_common
periph_gpio
periph_init
periph_init_gpio
periph_init_mcg
periph_init_pm
periph_init_uart
periph_init_wdog
periph_mcg
periph_pm
periph_uart
periph_wdog
stdio_uart
sys
master, CPU_MODEL=s9keaz128aclh48 
auto_init
board
core
core_init
core_msg
core_panic
cortexm_common
cortexm_common_periph
cpu
newlib
newlib_nano
newlib_syscalls_default
periph
periph_common
periph_gpio
periph_ics
periph_init
periph_init_gpio
periph_init_ics
periph_init_pm
periph_init_uart
periph_init_wdog
periph_pm
periph_uart
periph_wdog
stdio_uart
sys
this branch 
auto_init
board
core
core_init
core_msg
core_panic
cortexm_common
cortexm_common_periph
cpu
newlib
newlib_nano
newlib_syscalls_default
periph
periph_common
periph_gpio
periph_init
periph_init_gpio
periph_init_mcg
periph_init_pm
periph_init_uart
periph_init_wdog
periph_mcg
periph_pm
periph_uart
periph_wdog
stdio_uart
sys
this branch, CPU_MODEL=s9keaz128aclh48 
auto_init
board
core
core_init
core_msg
core_panic
cortexm_common
cortexm_common_periph
cpu
newlib
newlib_nano
newlib_syscalls_default
periph
periph_common
periph_gpio
periph_ics
periph_init
periph_init_gpio
periph_init_ics
periph_init_pm
periph_init_uart
periph_init_wdog
periph_pm
periph_uart
periph_wdog
stdio_uart
sys

@PeterKietzmann PeterKietzmann added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels May 26, 2020
PeterKietzmann
PeterKietzmann approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@PeterKietzmann PeterKietzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@PeterKietzmann PeterKietzmann merged commit 4831300 into RIOT-OS:master May 26, 2020
@leandrolanzieri leandrolanzieri deleted the pr/cpu/kinetis/cleanup_dependencies branch August 7, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterKietzmann PeterKietzmann PeterKietzmann approved these changes

@aabadie aabadie Awaiting requested review from aabadie

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
3 participants
@leandrolanzieri @PeterKietzmann @benpicco