-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add color depth types to disp_dev API #14054
base: master
Are you sure you want to change the base?
Conversation
*/ | ||
typedef struct { | ||
bool black; | ||
bool color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about this though. Maybe storing it in one uint8_t
is better. Or maybe two booleans is better for the compiler to optimize.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions. |
"State: don't stale" Still an open topic |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions. |
Still an issue. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions. |
Hi! |
Contribution description
This PR addresses the issue with colors in the disp_dev API. Mentioned briefly in #13787
It's a proposal how to address it.
The idea behind this is simple: The user application shouldn't care too much about the underlying color depth of a display.
It should provide the color data in the correct format. The driver should do the rest. This also makes it possible to switch displays with different color depths without changing the color data itself. Also the application code should be the same. The user only has to change the makefile.
For example:
This is an down scaling example. The same can be done for up scaling as well.
The biggest benefit is backwards compatibility. The user can simply maintain backwards compatibility, without caring too much about the old hardware.
Testing procedure
The tests are not changed yet.
Issues/PRs references
Addresses #13787 . Should be merged after #14051 .