Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bmp config for nrf52 #13972

Merged
merged 1 commit into from
May 12, 2020
Merged

Add bmp config for nrf52 #13972

merged 1 commit into from
May 12, 2020

Conversation

Citrullin
Copy link
Contributor

@Citrullin Citrullin commented Apr 28, 2020 •
edited
Loading

Contribution description

Using PROGRAMMER=bmp for nrf52 boards failed. This should do the job.

Testing procedure

Tested it with nrf52dk.

  1. Flash a black magic probe on a bluepill or use the official bmp.
  2. Connect the blackmagicprobe accordingly.
  3. Use PROGRAMMER=bmp to flash your application. make term also works.

@benpicco benpicco added Area: tools Area: Supplementary tools Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Apr 28, 2020
@benpicco benpicco requested a review from maribu May 1, 2020 12:42
@benpicco benpicco added CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 1, 2020
benpicco
benpicco reviewed May 1, 2020
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward.

It would probably be good though if we wouldn't have to do this on a per-board basis, but could just have a $(RIOTMAKE)/tools/debugger.inc.mk that allowed us to use any debugger with any board.

@maribu
Copy link
Member

maribu commented May 2, 2020

I can't test now. I have my nRF52 boards in the office (and I'm doing mostly home office now). But code-wise it looks good. I would be very surprised, if this wouldn't just work.

@benpicco
Copy link
Contributor

benpicco commented May 7, 2020

Uh one more thing: please change the commit message to something like boards/common/nrf52: add config for bmp

@maribu
Copy link
Member

maribu commented May 11, 2020

@Citrullin: It seems only the requested change of the commit message is missing to get this merged.

@Citrullin
Copy link
Contributor Author

@Citrullin: It seems only the requested change of the commit message is missing to get this merged.

Thanks for reminding me. Done.

@Citrullin Citrullin mentioned this pull request May 12, 2020
Open
@benpicco benpicco merged commit e359153 into RIOT-OS:master May 12, 2020
@miri64 miri64 added this to the Release 2020.07 milestone Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@maribu maribu Awaiting requested review from maribu

Assignees
No one assigned
Labels
Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
4 participants
@Citrullin @maribu @benpicco @miri64