-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards/pinetime: add defines for controlling the backlight pin #13657
boards/pinetime: add defines for controlling the backlight pin #13657
Conversation
Why defines? (Why are defines creeping into the codebase lately?) |
I'm adding one in disp_dev. But we need a common define at board level. |
We need a way to 1. define a common pin and 2. define whether it is active low or active high. The current macros allow for that, but a set of common defines to select a |
f09d4ec
to
2df63d2
Compare
@kaspar030 Are you okay with the current changes here or do you have a different proposal? |
@kaspar030 mentioned offline that he is fine with the current changes as it is an iprovement of the current state, but that we're going to run into issues with multiple displays and when hooking up a display to an existing board. |
@aabadie Please squash! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack!
e74bfc0
to
6202e2d
Compare
Squashed! |
Contribution description
This PR adds some defines (
BACKLIGHT_ON
,BACKLIGHT_OFF
) for controlling the Pinetime backlight pin.These defines are meant to be generic, similar to on-board LED macros, and should be defined in boards that need it (the adafruit-clue needs it for example).
Testing procedure
tests/driver_ili9341
,tests/disp_dev
andtests/pkg_lvgl
are displaying something on the pinetimeexamples/hello-world
) the screen remains off.Issues/PRs references
Will help with #13276