gnrc/lorawan: support for single channel gateways #13590

gschorcht · 2020-03-08T14:23:43Z

Contribution description

This PR allows the use of gnrc/lorawan with single channel gateways.

There are a number of cheap single/dual channel gateways on the market, for example the Dragino LG02. Although they are not recommended for LoRaWAN use, they are inexpensive tools for playing with and testing RIOT's LoRa functions. However, the use of different channels for the join procedure and the send function avoids the use of such a single-channel gateway.

Therefore, this PR introduces a compile time variable GNRC_LORAWAN_SINGLE_CHANNEL, which can be used to define a single frequency. When this variable is defined, only this frequency is set in gnrc_lorawan_default_channels during initialization and the channel configuration in gnrc_lorawan_process_cflist after joining is disabled.

Testing procedure

Set ENABLE_DEBUG to 1 in drivers/sx127x/sx172x_getset.c and flash examples/gnrc_lorawan for any LoRa-Board with

CFLAGS='-DGNRC_LORAWAN_SINGLE_CHANNEL=868100000UL ...' make BOARD=... -C examples/gnrc_lorawan flash

Use command ifconfig 4 up to join and send 4 RIOT afterwards. All sx172x_set_channel calls should show the configured frequency.

[sx127x] Set channel: 868100000

Issues/PRs references

jia200x · 2020-03-09T09:50:06Z

sys/net/gnrc/link_layer/lorawan/gnrc_lorawan_region.c

@@ -96,6 +96,10 @@ uint32_t gnrc_lorawan_pick_channel(gnrc_lorawan_t *mac)

 void gnrc_lorawan_process_cflist(gnrc_lorawan_t *mac, uint8_t *cflist)
 {
+#ifdef GNRC_LORAWAN_SINGLE_CHANNEL


have you checked if the Join Procedure sends the channel list?
If so, there's no need add this guard.

Yep, tested with TTN. The Join_Accecpt contains the optional channel list.

ah true, it's the same network server :)

jia200x · 2020-03-09T14:11:37Z

sys/net/gnrc/link_layer/lorawan/gnrc_lorawan_region.c

+#ifdef GNRC_LORAWAN_SINGLE_CHANNEL
+    (void)mac;
+    (void)cflist;
+#else


Suggested change

#ifdef GNRC_LORAWAN_SINGLE_CHANNEL

(void)mac;

(void)cflist;

#else

if(!IS_USED(GNRC_LORAWAN_SINGLE_CHANNEL)) {

I don't think this can be done. As I understand, @gschorcht proposes that GNRC_LORAWAN_SINGLE_CHANNEL holds the single frequency value, so it would not be a boolean switch.

Yes, GNRC_LORAWAN_SINGLE_CHANNEL defines a value. IS_USED and IS_ACTIVE test for a macro that is 1, 0 or not defined. So they are not applicable here.

ah, misread and though it was a boolean

sys/net/gnrc/link_layer/lorawan/gnrc_lorawan_region.c

jia200x · 2020-03-09T14:43:56Z

please squash

gschorcht · 2020-03-09T16:06:51Z

Squashed

leandrolanzieri · 2020-04-07T07:18:07Z

sys/include/net/gnrc/lorawan/region.h

@@ -29,11 +29,16 @@ extern "C" {
 * @brief Default LoRaWAN channels for current region (EU868)
 */
 static const uint32_t gnrc_lorawan_default_channels[] = {
+#ifdef GNRC_LORAWAN_SINGLE_CHANNEL


Documentation on this option should be added.

miri64 · 2020-06-25T14:54:39Z

@gschorcht @leandrolanzieri any progress?

gschorcht · 2020-06-25T15:14:51Z

@miri64 Thanks for going through all these PR and pushing them a bit 👍

As I see it, only the option needs to be documented. I will try to do it in next days.

stale · 2021-01-14T04:36:58Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

tmp1

stale · 2022-04-30T10:45:38Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

gschorcht requested review from cgundogan, haukepetersen, miri64 and PeterKietzmann as code owners March 8, 2020 14:23

gschorcht requested review from jia200x and removed request for haukepetersen, miri64, cgundogan and PeterKietzmann March 8, 2020 14:24

gschorcht added Area: LoRa Area: LoRa radio support CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Mar 8, 2020

jia200x reviewed Mar 9, 2020

View reviewed changes

sys/net/gnrc/link_layer/lorawan/gnrc_lorawan_region.c Outdated Show resolved Hide resolved

gschorcht force-pushed the gnrc/lorawan/single_channel_gateway branch from 6e858d5 to 3f54b94 Compare March 9, 2020 15:02

benpicco added this to the Release 2020.04 milestone Mar 29, 2020

benpicco requested a review from aabadie March 29, 2020 15:38

leandrolanzieri requested a review from jia200x April 7, 2020 07:12

leandrolanzieri reviewed Apr 7, 2020

View reviewed changes

leandrolanzieri modified the milestones: Release 2020.04, Release 2020.07 Apr 9, 2020

miri64 modified the milestones: Release 2020.07, Release 2020.10 Jul 10, 2020

stale bot added the State: stale State: The issue / PR has no activity for >185 days label Jan 14, 2021

gschorcht added State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet and removed State: stale State: The issue / PR has no activity for >185 days labels Jan 14, 2021

jia200x modified the milestones: Release 2020.10, Release 2021.01, Release 2021.04 Jan 14, 2021

kaspar030 modified the milestones: Release 2021.04, Release 2021.07 Apr 23, 2021

MrKevinWeiss removed this from the Release 2021.07 milestone Jul 15, 2021

gnrc/lorawan: support for single channel gateways

5d48995

tmp1

gschorcht force-pushed the gnrc/lorawan/single_channel_gateway branch from 3f54b94 to 5d48995 Compare October 26, 2021 22:24

github-actions bot added Area: network Area: Networking Area: sys Area: System labels Oct 26, 2021

fixup! gnrc/lorawan: support for single channel gateways

51c9e74

stale bot added the State: stale State: The issue / PR has no activity for >185 days label Apr 30, 2022

gschorcht added State: don't stale State: Tell state-bot to ignore this issue and removed State: stale State: The issue / PR has no activity for >185 days labels Apr 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gnrc/lorawan: support for single channel gateways #13590

gnrc/lorawan: support for single channel gateways #13590

gschorcht commented Mar 8, 2020

jia200x Mar 9, 2020

gschorcht Mar 9, 2020

jia200x Mar 9, 2020

jia200x Mar 9, 2020 •

edited

Loading

gschorcht Mar 9, 2020

leandrolanzieri Apr 7, 2020

gschorcht Apr 7, 2020 •

edited

Loading

jia200x Apr 7, 2020

jia200x commented Mar 9, 2020

gschorcht commented Mar 9, 2020

leandrolanzieri Apr 7, 2020

miri64 commented Jun 25, 2020

gschorcht commented Jun 25, 2020

stale bot commented Jan 14, 2021

stale bot commented Apr 30, 2022

gnrc/lorawan: support for single channel gateways #13590

Are you sure you want to change the base?

gnrc/lorawan: support for single channel gateways #13590

Conversation

gschorcht commented Mar 8, 2020

Contribution description

Testing procedure

Issues/PRs references

jia200x Mar 9, 2020

Choose a reason for hiding this comment

gschorcht Mar 9, 2020

Choose a reason for hiding this comment

jia200x Mar 9, 2020

Choose a reason for hiding this comment

jia200x Mar 9, 2020 • edited Loading

Choose a reason for hiding this comment

gschorcht Mar 9, 2020

Choose a reason for hiding this comment

leandrolanzieri Apr 7, 2020

Choose a reason for hiding this comment

gschorcht Apr 7, 2020 • edited Loading

Choose a reason for hiding this comment

jia200x Apr 7, 2020

Choose a reason for hiding this comment

jia200x commented Mar 9, 2020

gschorcht commented Mar 9, 2020

leandrolanzieri Apr 7, 2020

Choose a reason for hiding this comment

miri64 commented Jun 25, 2020

gschorcht commented Jun 25, 2020

stale bot commented Jan 14, 2021

stale bot commented Apr 30, 2022

jia200x Mar 9, 2020 •

edited

Loading

gschorcht Apr 7, 2020 •

edited

Loading