Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/microduino-corerf: doc SPI and I2C pin mapping #12883

Merged
merged 1 commit into from
Dec 5, 2019
Merged

boards/microduino-corerf: doc SPI and I2C pin mapping #12883

merged 1 commit into from
Dec 5, 2019

Conversation

fabian18
Copy link
Contributor

@fabian18 fabian18 commented Dec 5, 2019

Contribution description

This PR extends the documentation of the microduino-corerf with pin mappings of peripheral interfaces SPI and I2C.

Testing procedure

  • Copied from the wiki
  • Tested an AT86RF233, connected via SPI

@benpicco benpicco added Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Dec 5, 2019
@maribu maribu requested a review from benpicco December 5, 2019 19:16
maribu
maribu reviewed Dec 5, 2019
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a pity that a figure like this is not available for the CoreRF:

pinout Core (no-RF)

(Above is the ATmega328P variant, not the ATmega128RFA1 variant.)

@benpicco
Copy link
Contributor

benpicco commented Dec 5, 2019

Tested an AT86RF233, connected via SPI

The irony of this is not lost on me 😄

benpicco
benpicco approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good addition.

@benpicco benpicco merged commit 03b95ef into RIOT-OS:master Dec 5, 2019
@maribu
Copy link
Member

maribu commented Dec 5, 2019

Tested an AT86RF233, connected via SPI

The irony of this is not lost on me smile

@fabian18 is working on allowing to use multiple AT86RF2xx transceivers of different flavors to be used by properly factoring out the differences instead of #ifdef .... #endif. It would of course make more sense to combine the ATmega128RFA1 with the sub-gigahertz version of the AT86RF2xx. But we (currently) have none of it.

@fabian18 fabian18 deleted the microduino-corerf-doc-pin-mapping branch December 8, 2019 16:12
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu left review comments

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.01
Development

Successfully merging this pull request may close these issues.
4 participants
@fabian18 @benpicco @maribu @fjmolinas