sys/fmt: add fmt_is_number() #12878
Merged
sys/fmt: add fmt_is_number() #12878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haukepetersen
added
Type: cleanup
haukepetersen
force-pushed
the
add_fmt_isnumber
branch
from
9d5e45a to
f97bb41
Compare
kaspar030
requested changes
Dec 5, 2019
| @@ -20,6 +20,28 @@ | |||
| #include "fmt.h" | |||
| #include "tests-fmt.h" | |||
|
|
|||
| static void test_fmg_is_x(void) | |||
There was a problem hiding this comment.
typo here and below: fmg -> fmt
There was a problem hiding this comment.
of course, fixed.
kaspar030
reviewed
Dec 5, 2019
sys/fmt/fmt.c
Outdated
| { | ||
| return (c >= 'A' && c <= 'Z'); | ||
| } | ||
| if (!str) { |
There was a problem hiding this comment.
Suggested change
| if (!str) { | |
| if (!str || !*str) { |
otherwise an empty string would be considered a number.
There was a problem hiding this comment.
make sense, fixed.
haukepetersen
force-pushed
the
add_fmt_isnumber
branch
from
f97bb41 to
cea260b
Compare
|
addressed comments. |
kaspar030
added
the
CI: run tests
|
Sorry, tests were not run, I'll re-trigger. |
kaspar030
added
CI: ready for build
kaspar030
approved these changes
Dec 5, 2019
|
ACK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The
_is_number()function is currently duplicated in the RIOT code base at two locations. Furthermore, I need the same function in some other module - and I really don't want to duplicate it even further... So I added that function to thefmtmodule.So this PR does the following:
fmt_is_digit()andfmt_is_upper()to thefmts modules public APIfmt_is_number()function to thefmtmoduletests/driver_kw2xrfandshell/commands/sc_gnrc_netifusefmt_is_number()instead of their local implementationsNote: while moving the
is_number()function, I altered it slightly: (i) useintinstead ofbool, to keep thefmts modules dependencies to the stdlib low, and (ii) also check the input string for beingNULLso the function does not returntrueon empty strings.Testing procedure
Run unittests and check the build output for
tests/driver_kw2xrfandexamples/gnrc_networking.Issues/PRs references
none