Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: replace GNU cp -t with standard cp #12875

Merged
merged 2 commits into from
Dec 5, 2019

Conversation

smlng
Copy link
Member

@smlng smlng commented Dec 5, 2019

Contribution description

UNIX cp command does not have the -t option like its GNU variant.
Hence, it usage breaks building RIOT e.g. on FreeBSD.

Testing procedure

If CI is happy this should be good.

Issues/PRs references

cp -t was introduces by #12695 and #11818

smlng added 2 commits December 5, 2019 09:12
UNIX `cp` command does not have the `-t` option like its GNU variant.
Hence, it usage breaks building RIOT e.g. on FreeBSD.
UNIX `cp` command does not have the `-t` option like its GNU variant.
Hence, it usage breaks building RIOT e.g. on FreeBSD.
@smlng smlng added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: tools Area: Supplementary tools labels Dec 5, 2019
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ACK!

@leandrolanzieri leandrolanzieri merged commit cf6a0b4 into RIOT-OS:master Dec 5, 2019
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants