-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/jerryscript: set -Wno-conversion for FreeBSD #12865
Conversation
@smlng do you have some vagrant or puppet config for your FreeBSD setup? |
nope, currently its just a box that I connected to our HIL Jenkins and I install stuff by demand, i.e. when a build fails I check if its a tool missing or an issue (like this one). But I could certainly provide something to setup FreeBSD for RIOT from scratch, soonish. |
@miri64 here build results for this PR, specifically look at
Ignore the error for dtls-echo, I already made PR on upstream: |
How can I read the actual error? It just reads
That one only shows results for tests.
Ignored ;-) |
in the CI script I use |
more verbose results (still running, when writing this):
|
Fixes compile issue on FreeBSD because of float to double conversion by disabling the corresponding compiler warning.
8833c28
to
5dd03b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With regards to the specific warning fixed the deactivated warning option is fine
In file included from /usr/home/jenkins/workspace/RIOT-FreeBSD/examples/javascript/bin/pkg/native/jerryscript/jerry-ext/arg/arg-transform-functions.c:16:
/usr/home/jenkins/workspace/RIOT-FreeBSD/examples/javascript/bin/pkg/native/jerryscript/jerry-ext/arg/arg-transform-functions.c: In function 'jerryx_arg_helper_process_double':
/usr/home/jenkins/workspace/RIOT-FreeBSD/examples/javascript/bin/pkg/native/jerryscript/jerry-ext/arg/arg-transform-functions.c:135:14: error: conversion from 'double' to 'float' may change value [-Werror=float-conversion]
135 | if (isnan (*d))
isnan()
is for both double
and float
. When Updating the package we should however re-test if no other conversion errors sneak in.
Thanks for the extra work in providing the results @smlng! |
Contribution description
Fixes compile issue on FreeBSD because of float to double conversion
by disabling the corresponding compiler warning.
Testing procedure
Compile
examples/javascript
on FreeBSD for native, it fails on master with compile warning-Wfloat-conversion
. This PR disables this warning similar to other exceptions already in place for jerryscript package.Issues/PRs references