Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/jerryscript: set -Wno-conversion for FreeBSD #12865

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

smlng
Copy link
Member

@smlng smlng commented Dec 3, 2019

Contribution description

Fixes compile issue on FreeBSD because of float to double conversion
by disabling the corresponding compiler warning.

Testing procedure

Compile examples/javascript on FreeBSD for native, it fails on master with compile warning -Wfloat-conversion. This PR disables this warning similar to other exceptions already in place for jerryscript package.

Issues/PRs references

@smlng smlng added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: pkg Area: External package ports labels Dec 3, 2019
@miri64
Copy link
Member

miri64 commented Dec 3, 2019

@smlng do you have some vagrant or puppet config for your FreeBSD setup?

@smlng
Copy link
Member Author

smlng commented Dec 3, 2019

nope, currently its just a box that I connected to our HIL Jenkins and I install stuff by demand, i.e. when a build fails I check if its a tool missing or an issue (like this one).

But I could certainly provide something to setup FreeBSD for RIOT from scratch, soonish.

@smlng smlng added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 5, 2019
@smlng
Copy link
Member Author

smlng commented Dec 5, 2019

@miri64 here build results for this PR, specifically look at examples/javascript:

Ignore the error for dtls-echo, I already made PR on upstream:

eclipse-tinydtls/tinydtls#21

@miri64
Copy link
Member

miri64 commented Dec 5, 2019

@miri64 here build results for this PR, specifically look at examples/javascript:

* master, failing: https://ci.riot-os.org/hil/blue/organizations/jenkins/RIOT-FreeBSD/detail/RIOT-FreeBSD/18/pipeline/21

How can I read the actual error? It just reads

+ BOARDS=native gmake -C examples/javascript buildtest

gmake: Entering directory '/usr/home/jenkins/workspace/RIOT-FreeBSD/examples/javascript'

Building for native ... failed!

gmake: *** [/usr/home/jenkins/workspace/RIOT-FreeBSD/makefiles/buildtests.inc.mk:6: buildtest] Error 1

gmake: Leaving directory '/usr/home/jenkins/workspace/RIOT-FreeBSD/examples/javascript'

script returned exit code 2
* this PR, fixed: https://ci.riot-os.org/hil/blue/organizations/jenkins/RIOT-FreeBSD/detail/RIOT-FreeBSD/19/pipeline/23

That one only shows results for tests.

Ignore the error for dtls-echo, I already made PR on upstream:

eclipse/tinydtls#21

Ignored ;-)

@smlng
Copy link
Member Author

smlng commented Dec 5, 2019

in the CI script I use make buildtest which hides most of the details. I think I need to unset BUILDTEST_MAKE_REDIRECT to show results, I'll try and report back

@smlng
Copy link
Member Author

smlng commented Dec 5, 2019

more verbose results (still running, when writing this):

Fixes compile issue on FreeBSD because of float to double conversion
by disabling the corresponding compiler warning.
@smlng smlng force-pushed the pr_freebsd_jerryscript branch from 8833c28 to 5dd03b9 Compare December 5, 2019 12:32
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With regards to the specific warning fixed the deactivated warning option is fine

In file included from /usr/home/jenkins/workspace/RIOT-FreeBSD/examples/javascript/bin/pkg/native/jerryscript/jerry-ext/arg/arg-transform-functions.c:16:

/usr/home/jenkins/workspace/RIOT-FreeBSD/examples/javascript/bin/pkg/native/jerryscript/jerry-ext/arg/arg-transform-functions.c: In function 'jerryx_arg_helper_process_double':

/usr/home/jenkins/workspace/RIOT-FreeBSD/examples/javascript/bin/pkg/native/jerryscript/jerry-ext/arg/arg-transform-functions.c:135:14: error: conversion from 'double' to 'float' may change value [-Werror=float-conversion]

  135 |   if (isnan (*d))

isnan() is for both double and float. When Updating the package we should however re-test if no other conversion errors sneak in.

@miri64 miri64 merged commit 7ffc30a into RIOT-OS:master Dec 5, 2019
@miri64
Copy link
Member

miri64 commented Dec 5, 2019

Thanks for the extra work in providing the results @smlng!

@smlng smlng deleted the pr_freebsd_jerryscript branch December 5, 2019 14:24
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants