Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-notes.txt: add notes for 2019.10 release #12598

Merged
merged 1 commit into from
Oct 31, 2019
Merged

release-notes.txt: add notes for 2019.10 release #12598

merged 1 commit into from
Oct 31, 2019

Conversation

kb2ma
Copy link
Member

@kb2ma kb2ma commented Oct 29, 2019

Contribution description

Release notes for 2019.10 release

Testing procedure

Please review the sections you are familiar with and markup any omissions or mistakes. Thanks!

@kb2ma kb2ma added Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Process: release cycle Integration Process: The PR is connected to the release cycle (e.g. release notes) labels Oct 29, 2019
@kb2ma kb2ma added this to the Release 2019.10 milestone Oct 29, 2019
@kb2ma kb2ma requested a review from a team October 29, 2019 04:26
miri64
miri64 previously requested changes Oct 29, 2019
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you prefer it? Would you like to address change requests yourself or should we just PR against your branch?

aabadie
aabadie reviewed Oct 29, 2019
View reviewed changes
aabadie
aabadie reviewed Oct 29, 2019
View reviewed changes
aabadie
aabadie reviewed Oct 29, 2019
View reviewed changes
aabadie
aabadie reviewed Oct 29, 2019
View reviewed changes
aabadie
aabadie reviewed Oct 29, 2019
View reviewed changes
@kb2ma
Copy link
Member Author

kb2ma commented Oct 29, 2019

Would you like to address change requests yourself or should we just PR against your branch?

@miri64, @aabadie -- thanks for the detailed reviews. I think I can update these pretty quickly. Give me an hour or two.

@kb2ma
Copy link
Member Author

kb2ma commented Oct 29, 2019

All comments addressed.

@miri64 miri64 self-requested a review October 29, 2019 13:31
@miri64 miri64 dismissed their stale review October 29, 2019 13:31

Comments were addressed.

@kb2ma
Copy link
Member Author

kb2ma commented Oct 29, 2019

Just pushed a fixup for the count of issues fixed. I thought I already had updated that value from 70 to 60, but apparently not.

@kb2ma
Copy link
Member Author

kb2ma commented Oct 30, 2019

Pushed a fixup found while reviewing the 'dump issues' PR in RIOT-release-manager.

@kb2ma
Copy link
Member Author

kb2ma commented Oct 30, 2019

I would like to release tomorrow (31 Oct), so would appreciate an ACK. @aabadie, would you please confirm the changes resolve the issues you raised.

@aabadie
Copy link
Contributor

aabadie commented Oct 30, 2019

@aabadie, would you please confirm the changes resolve the issues you raised.

I confirm all are resolved now.

miri64
miri64 approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash. @RIOT-OS/maintainers (and contributors but I don't want to spam everyone ;-)) for those who didn't yet, please have a look if your changes of the past release cycle are sufficiently reflected.

@kb2ma
Copy link
Member Author

kb2ma commented Oct 31, 2019

No objections, so merging.

@kb2ma kb2ma merged commit 85a392e into RIOT-OS:master Oct 31, 2019
@kb2ma kb2ma mentioned this pull request Oct 31, 2019
Merged
@kb2ma
Copy link
Member Author

kb2ma commented Oct 31, 2019

Backport provided in #12619

@herjulf herjulf mentioned this pull request Nov 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie left review comments

@miri64 miri64 miri64 approved these changes

Assignees
No one assigned
Labels
Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Process: release cycle Integration Process: The PR is connected to the release cycle (e.g. release notes)
Projects
None yet
Milestone
Release 2019.10
Development

Successfully merging this pull request may close these issues.
3 participants
@kb2ma @aabadie @miri64