Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu: mips*: Reorganize headers #12477

Merged
merged 5 commits into from
Oct 21, 2019
Merged

cpu: mips*: Reorganize headers #12477

merged 5 commits into from
Oct 21, 2019

Conversation

francois-berder
Copy link
Contributor

Contribution description

Reorganize headers in cpu/mips32r2_common, cpu/mips_pic32_common, cpu/mips_pic32mx and cpu/mips_pic32mzto make it more similar to other cpu architectures.

Testing procedure

This PR does not introduce any new features so hopefully everything should continue working.
Compile hello-world and check that the UART output is correct.

Issues/PRs references

None.

@francois-berder
makefiles: arch: mips: Define CPU_MODEL in CFLAGS
9af14d7 
Signed-off-by: Francois Berder <18538310+francois-berder@users.noreply.github.com>
@francois-berder
cpu: mips_pic32mz: Include vendor header in cpu_conf.h
57377de 
Signed-off-by: Francois Berder <18538310+francois-berder@users.noreply.github.com>
@benpicco benpicco added Platform: MIPS Platform: This PR/issue effects MIPS-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 17, 2019
@benpicco
Copy link
Contributor

Murdock found some doxygen issues.
Otherwise this looks good.

@francois-berder francois-berder mentioned this pull request Oct 17, 2019
Merged
@francois-berder
Copy link
Contributor Author

Murdock fails because my PR needs squashing. Apart from that, the doxygen warnings were fixed and the PR is ready for review.

@benpicco
Copy link
Contributor

Go ahead and squash then!

@francois-berder
cpu: mips_pic32_common: Move cpu header to mips32r2_common
3a62b62 
Signed-off-by: Francois Berder <18538310+francois-berder@users.noreply.github.com>
@francois-berder
cpu: mips32r2_common: Remove useless includes
89d43c3 
Signed-off-by: Francois Berder <18538310+francois-berder@users.noreply.github.com>
@francois-berder
cpu: mips_pic32mx: Include vendor header in cpu_conf.h
12c3a54 
Signed-off-by: Francois Berder <18538310+francois-berder@users.noreply.github.com>
benpicco
benpicco approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only moves code around.
Murdock run should be enough.

@benpicco benpicco merged commit 80c0033 into RIOT-OS:master Oct 21, 2019
@francois-berder francois-berder deleted the mips-refactor branch October 24, 2019 18:03
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: MIPS Platform: This PR/issue effects MIPS-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.01
Development

Successfully merging this pull request may close these issues.
3 participants
@francois-berder @benpicco @fjmolinas