Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: prepare for RIOT-OS/Release-Specs#137 #12375

Merged
merged 2 commits into from
Oct 10, 2019

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Oct 4, 2019

Do not merge yet!

Contribution description

This is a PR in preparation (and anticipation 😉) of RIOT-OS/Release-Specs#137. While adding IPv6 fragmentation to the test shouldn't really harm, we should wait for the discussion there, before we add unnecessary code to the test.

Testing procedure

Should still compile, the proposed release specs (TBD), resulting from RIOT-OS/Release-Specs#137 should pass.

Issues/PRs references

RIOT-OS/Release-Specs#137

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: tests Area: tests and testing framework labels Oct 4, 2019
@miri64 miri64 added this to the Release 2019.10 milestone Oct 4, 2019
@miri64 miri64 requested a review from leandrolanzieri October 4, 2019 18:09
@miri64 miri64 added the Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR label Oct 4, 2019
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 10, 2019
@kb2ma
Copy link
Member

kb2ma commented Oct 10, 2019

ACK. Please squash.

@miri64
Copy link
Member Author

miri64 commented Oct 10, 2019

Squashed.

@kb2ma
Copy link
Member

kb2ma commented Oct 10, 2019

Looks like insufficient memory issues.

@miri64 miri64 force-pushed the tests/enh/rs-i137 branch from f429390 to 9e62584 Compare October 10, 2019 17:02
@miri64
Copy link
Member Author

miri64 commented Oct 10, 2019

Fixed my typos and squashed.

@kb2ma
Copy link
Member

kb2ma commented Oct 10, 2019

Perfect, thanks.

@kb2ma kb2ma merged commit 9946e24 into RIOT-OS:master Oct 10, 2019
@miri64 miri64 deleted the tests/enh/rs-i137 branch March 4, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants