edbg: verify before flash #12301
Merged
edbg: verify before flash #12301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit overrides the default flash recipe with an edbg specific one. The new recipe first verifies the flashfile agains the device flash. If it is already on there, it won't get overridden. edbg takes care of resetting the device in any case.
kaspar030
added
Type: enhancement
dylad
added
the
Reviewed: 3-testing
|
I am not a makefile specialist but it works. Verify is done before programming (with make flash or make flash-only) |
aabadie
approved these changes
Oct 1, 2019
There was a problem hiding this comment.
Tested this PR, it works as expected. Code changes are good too and follows the recommendations in #11093 (comment).
I also checked and functionally the changes are the same as in #11093 except that they are more nicely handled by overriding the flash-recipe target.
ACK and go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR overrides the flash recipe edit as suggested here edit when using edbg in order to make it verify before flash. This saves a flash cycle when the contents already match.
The first commit changes all edbg short options to use the long options. If the whole diff looks scary, take a look at the individual commits. :)
Testing procedure
With an edbg supported board, try
make all; make flash-only; make flash-onlyand observe that the first flashing actually programs the device, the second skips programming.Issues/PRs references
Supercedes #11093.