-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers/include/periph/eeprom: Changed uint8_t* to void* in API #11990
drivers/include/periph/eeprom: Changed uint8_t* to void* in API #11990
Conversation
|
As this is an API change, 2 ACKs are formally required. (This change will not break any caller, as @benpicco: Mind to have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK (1/2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Interestingly both implementations already cast the argument to uint8_t*
internally, so there really is no semantic change here.
Contribution description
This tiny PR changes the EEPROM API for eeprom_read and eeprom_write
to expect void* data instead of uint8_t* data. This suggests a more general interface.
Testing procedure
I executed tests/eepreg and tests/periph_eeprom on arduino-mega2560.
Issues/PRs references
This PR has emerged from PR #11929 .