Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/edbg: escape values set by 'env' #11645

Merged

Conversation

leandrolanzieri
Copy link
Contributor

@leandrolanzieri leandrolanzieri commented Jun 6, 2019

Contribution description

Right now, for instance, if a path with spaces exists in the PATH environmental variable, the build process of edbg fails. This PR escapes the values passed to env in the Makefile of edbg (I'm not quite sure if this is also needed for PKG_BULDDIR).

Testing procedure

Set either PATH or TERM variables to values that contain spaces and try to build edbg (e.g. by ensuring it is not in dist/tools/edbg/edbg and trying to flash some board that uses it, like samr21-xpro).

Issues/PRs references

None

@leandrolanzieri leandrolanzieri added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: build system Area: Build system labels Jun 6, 2019
@leandrolanzieri leandrolanzieri changed the title tools/edbg: escape values set by 'env' tools/egdb: escape values set by 'env' Jun 6, 2019
@leandrolanzieri leandrolanzieri changed the title tools/egdb: escape values set by 'env' tools/edbg: escape values set by 'env' Jun 6, 2019
Copy link
Contributor

@jcarrano jcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steps to test:

In the RIOT root, run:

$ mkdir -p ~/"a b"
$ rm -f dist/tools/edbg/edbg
$ PATH=$PATH:~/"a b" BOARD=samr21-xpro make -C examples/hello-world flash-only

Fails in master, works with this patch.

@jcarrano jcarrano added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 6, 2019
@jcarrano jcarrano merged commit 2f26f95 into RIOT-OS:master Jun 7, 2019
@leandrolanzieri leandrolanzieri deleted the pr/dist/tools/edbg_path_fix branch June 7, 2019 12:23
@leandrolanzieri
Copy link
Contributor Author

@jcarrano Thanks for reviewing

@MrKevinWeiss MrKevinWeiss added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants