tools/edbg: escape values set by 'env' #11645
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Right now, for instance, if a path with spaces exists in the PATH environmental variable, the build process of edbg fails. This PR escapes the values passed to
env
in the Makefile of edbg (I'm not quite sure if this is also needed forPKG_BULDDIR
).Testing procedure
Set either PATH or TERM variables to values that contain spaces and try to build edbg (e.g. by ensuring it is not in
dist/tools/edbg/edbg
and trying to flash some board that uses it, like samr21-xpro).Issues/PRs references
None