Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feather-m0: add usbdev feature #11636

Merged
merged 1 commit into from
Jun 6, 2019
Merged

feather-m0: add usbdev feature #11636

merged 1 commit into from
Jun 6, 2019

Conversation

ynezz
Copy link
Contributor

@ynezz ynezz commented Jun 5, 2019

Testing procedure

Tested this successfully with #11077

@ynezz
feather-m0: add usbdev feature
3b5d9f3 
Signed-off-by: Petr Štetiar <ynezz@true.cz>
@aabadie aabadie added Area: boards Area: Board ports Area: USB Area: Universal Serial Bus labels Jun 5, 2019
@dylad
Copy link
Member

dylad commented Jun 5, 2019

I don't have the board but it should be good.
Maybe @aabadie can give it a try quickly with examples/usbus_minimal and check lsusb output.

@dylad dylad added this to the Release 2019.07 milestone Jun 5, 2019
@dylad dylad added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 5, 2019
@aabadie
Copy link
Contributor

aabadie commented Jun 5, 2019

Maybe @aabadie can give it a try quickly with examples/usbus_minimal and check lsusb output.

Sure!

@miri64
Copy link
Member

miri64 commented Jun 5, 2019

Mine's the only one I have at home, but sadly tightly integrated into a project ^^.

@miri64
Copy link
Member

miri64 commented Jun 5, 2019

The project is this one ;-)

@miri64
Copy link
Member

miri64 commented Jun 5, 2019

This PR (+ #11085) would have helped a lot with debugging that back then 😁

aabadie
aabadie approved these changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's working:

[mer. juin  5 12:41:45 2019] usb 2-3.2: New USB device found, idVendor=1209, idProduct=0001, bcdDevice= 0.00
[mer. juin  5 12:41:45 2019] usb 2-3.2: New USB device strings: Mfr=3, Product=2, SerialNumber=0
[mer. juin  5 12:41:45 2019] usb 2-3.2: Product: USB device
[mer. juin  5 12:41:45 2019] usb 2-3.2: Manufacturer: RIOT-os.org

ACK

@aabadie aabadie merged commit 22ca766 into RIOT-OS:master Jun 6, 2019
This was referenced Jun 6, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: USB Area: Universal Serial Bus CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines
Projects
None yet
Milestone
Release 2019.07
Development

Successfully merging this pull request may close these issues.
4 participants
@ynezz @dylad @aabadie @miri64