board: remove exporting PORT_LINUX|PORT_DARWIN #11619
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
PORT_LINUX and PORT_DARWIN are evaluated by
makefiles/tools/serial.inc.mk
and some boards Makefile.include.Their value does not need to be exported.
This also globally removes the line saying that the exports are needed
for flash rule.
Updated the
buildsystem_sanity_check
script to prevent re-exporting these in the future.Review procedure
These variables are only used in included makefiles:
When looking in
boards/openmote-b
andboards/common/remote
we see that it should even use$(PORT)
there instead, but it is another fix.Testing procedure
The
PORT
is still correctly defined for Linux, forosx
you need to have a board to test it.The output is the same with this PR and in master.
Issues/PRs references
Removal of exports #10850
Mentioned in #10440