Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netdev/lora: add netdev_lora_rx_info structure for RX info #11144

Merged
merged 5 commits into from
Mar 8, 2019
Merged

netdev/lora: add netdev_lora_rx_info structure for RX info #11144

merged 5 commits into from
Mar 8, 2019

Conversation

jia200x
Copy link
Member

@jia200x jia200x commented Mar 8, 2019

Contribution description

This PR adds a generic RX info structure for LoRa devices. This obsoletes the netdev_sx127x_lora_packet_info_t structure, so MAC layers are not dependent on driver specific headers.

Testing procedure

Test documentation with make doc.
Test that tests/pkg_semtech_loramac, examples/lorawan and tests/drivers_sx127x compile with no errors.
You should be able to see these RX info with tests/drivers_sx127x

Issues/PRs references

Addresses #6797 (comment)
#11022

@jia200x jia200x added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: LoRa Area: LoRa radio support labels Mar 8, 2019
@jia200x jia200x requested review from miri64 and aabadie March 8, 2019 16:52
@jia200x jia200x mentioned this pull request Mar 8, 2019
Merged
@aabadie
Copy link
Contributor

aabadie commented Mar 8, 2019

There is one occurence of netdev_sx127x_lora_packet_info_t remaining in tests/driver_sx127x. First thing I tested ;)

@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 8, 2019
aabadie
aabadie approved these changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested all 3 available LoRa applications (I pushed a commit to fix tests/driver_sx127x) and all worked. The changes also make sense.

ACK

@aabadie aabadie merged commit d562af4 into RIOT-OS:master Mar 8, 2019
@danpetry danpetry added this to the Release 2019.04 milestone Mar 11, 2019
@jia200x jia200x mentioned this pull request Apr 3, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

@miri64 miri64 Awaiting requested review from miri64

Assignees
No one assigned
Labels
Area: LoRa Area: LoRa radio support CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.04
Development

Successfully merging this pull request may close these issues.
3 participants
@jia200x @aabadie @danpetry