pkg/semtech_loramac: add null pointer guards to semtech_loramac_radio… #11134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jia200x
force-pushed
the
pr/fix_semtech_netdev
branch
from
19a2cf9 to
ee93796
Compare
jia200x
added
Area: LoRa
MichelRottleuthner
approved these changes
Mar 7, 2019
There was a problem hiding this comment.
Tested with LORA_DRIVER=sx1272 make -C tests/pkg_semtech-loramac BOARD=nucleo-f303re all flash term and I-NUCLEO-SX1272D attached.
In master provoking an interrupt crashes the node, with this PR it keeps working.
Also changes are straight forward -> ACK
MichelRottleuthner
added
the
CI: ready for build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
See #11132 (comment)
Testing procedure
Testing procedure has to be done preferably without pull resistors (so no PR #11132).
Either touch the DIO3 in the board with a jumper wire or try to set it to high and low to trigger the interrupt. The application will crash without this PR.
Alternatively, call netdev->event_callback with NETDEV_EVENT_CAD_DONE. It will have the same effect.
Issues/PRs references
Indirectly #11132