Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/lwip: update pkg_url from git:// to https:// #11120

Merged
merged 1 commit into from
Mar 7, 2019
Merged

pkg/lwip: update pkg_url from git:// to https:// #11120

merged 1 commit into from
Mar 7, 2019

Conversation

fjmolinas
Copy link
Contributor

Contribution description

When cloning pkg repo I get a connection error using the actual link git://git.savannah.nongnu.org/lwip.git but no issue if I change it to https://git.savannah.nongnu.org/git/lwip.git. In every other pkg https:// is used to pull the repo.

Testing procedure

Run on master make -C tests/lwip.

OS version: Ubuntu 18.04
Git version: 2.17.1

Issues/PRs references

None

@aabadie aabadie requested a review from miri64 March 7, 2019 08:55
@aabadie aabadie added Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 7, 2019
@aabadie
Copy link
Contributor

aabadie commented Mar 7, 2019 •
edited
Loading

Thanks @fjmolinas. Just change the commit message to pkg/lwip: update url from git:// to https:// to be more inline with the contributing guidelines. Use git --amend and force push.

@fjmolinas fjmolinas changed the title lwip: change pkg_url grom git//... to https//... pkg/lwip: change pkg_url grom git//... to https//... Mar 7, 2019
@fjmolinas fjmolinas changed the title pkg/lwip: change pkg_url grom git//... to https//... pkg/lwip: change pkg_url grom git:// to https:// Mar 7, 2019
@fjmolinas fjmolinas changed the title pkg/lwip: change pkg_url grom git:// to https:// pkg/lwip: update pkg_url from git:// to https:// Mar 7, 2019
@fjmolinas
Copy link
Contributor Author

@aabadie Yep sorry for that, addressed the formatting on PR title and commit message

miri64
miri64 approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. https:// is the way to go nowadays.

@miri64 miri64 merged commit f4145b3 into RIOT-OS:master Mar 7, 2019
@danpetry danpetry added this to the Release 2019.04 milestone Mar 11, 2019
@fjmolinas fjmolinas deleted the pkg/lwip_fix_URL branch August 7, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees
No one assigned
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2019.04
Development

Successfully merging this pull request may close these issues.
4 participants
@fjmolinas @aabadie @miri64 @danpetry