Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/hifive1: fix hifive1 reset #11040

Merged
merged 3 commits into from
Mar 12, 2019
Merged

boards/hifive1: fix hifive1 reset #11040

merged 3 commits into from
Mar 12, 2019

Conversation

kaspar030
Copy link
Contributor

Contribution description

pm_reset() was not implemented, and make reset was non-functional on hifive1.
This PR fixes both.

Without this PR, "make test" is broken.

Testing procedure

  1. flash "tests/shell", try "reboot" with and without this PR
  2. try "make term" in one terminal, then "make reset" in another
  3. flash "tests/shell", run "make test"

Issues/PRs references

none

@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms labels Feb 20, 2019
@kaspar030
Copy link
Contributor Author

@kenrabold can you maybe take a look?

This was referenced Feb 20, 2019
Closed
Merged
@kenrabold
Copy link
Contributor

The reboot code using the watchdog timer works for me. Looks good.

jcarrano
jcarrano reviewed Mar 1, 2019
View reviewed changes
dist/tools/openocd/openocd.sh Outdated
@@ -323,7 +323,7 @@ do_reset() {
-c 'telnet_port 0' \
-c 'gdb_port 0' \
-c 'init' \
-c 'reset run' \
-c "${OPENOCD_CMD_RESET_RUN:-reset run}" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new variable in the script. It should be documented at the beginning like the rest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, done.

@kaspar030
Copy link
Contributor Author

@jcarrano could you take another look?

@kaspar030 kaspar030 mentioned this pull request Mar 11, 2019
Merged
jcarrano
jcarrano suggested changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@jcarrano jcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to flash a pba-whatever (the yellow board) and got a small issue. Otherwise it's fine since it seems to work for people with the hifive board.

@kaspar030 kaspar030 added CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 11, 2019
@jcarrano jcarrano added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Mar 12, 2019
jcarrano
jcarrano approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@jcarrano jcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested that it still works with other boards. Needs squash.

@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 12, 2019
@jcarrano jcarrano merged commit b50ad9e into RIOT-OS:master Mar 12, 2019
@kaspar030 kaspar030 deleted the fix_hifive1_reset branch March 12, 2019 14:54
@danpetry danpetry added this to the Release 2019.04 milestone Mar 26, 2019
@kaspar030 kaspar030 mentioned this pull request Apr 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcarrano jcarrano jcarrano approved these changes

Assignees
No one assigned
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2019.04
Development

Successfully merging this pull request may close these issues.
4 participants
@kaspar030 @kenrabold @jcarrano @danpetry