sx127x: 2 fixes and 1 enhancement (replaces #10917) #10932
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
1 bugfix, 1 fix and 1 enhancement for sx127x driver (sx1272/sx1276 Lora chipset)
Bugfix for sending in implicit headers mode
Fix for netdev send call (remove duplicate code + bugfix for sx127x_set_tx())
Enhancement: set chipset's ValidHeader interrupt to NETDEV_EVENT_RX_STARTED netdev event
Testing procedure
To test enhancement, add NETDEV_EVENT_RX_STARTED catching code in event callback function
Issues/PRs references
Replaces PR #10917