Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alpha #69

Merged
merged 3 commits into from
Oct 28, 2021
Merged

Alpha #69

merged 3 commits into from
Oct 28, 2021

Conversation

jeremyary
Copy link
Contributor

Description

Verification Steps

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist (Definition of Done)

  • All acceptance criteria specified in JIRA or in issue number have been completed
  • Unit tests added that prove the fix is effective or the feature works
  • Documentation added for the feature
  • all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

jeremyary and others added 3 commits October 20, 2021 13:38
@jeremyary jeremyary merged commit 2677174 into main Oct 28, 2021
jianrongzhang89
jianrongzhang89 reviewed Oct 28, 2021
View reviewed changes
Copy link
Collaborator

@jianrongzhang89 jianrongzhang89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianrongzhang89 jianrongzhang89 jianrongzhang89 left review comments

@redhatHameed redhatHameed Awaiting requested review from redhatHameed redhatHameed is a code owner

@tchughesiv tchughesiv Awaiting requested review from tchughesiv tchughesiv is a code owner

@xieshenzh xieshenzh Awaiting requested review from xieshenzh xieshenzh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremyary @jianrongzhang89