Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SD_WS_48 TFA JOKER Temperature transmitter 30.3212 #1271

Merged
merged 7 commits into from
Sep 8, 2024

Conversation

elektron-bbs
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)
    No decoding was implemented so far, see 'Joker' Funk-Thermometer TFA Dostmann #92

  • What is the new behavior (if this is a feature change)?
    Decoding is now realized.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 82.92683% with 7 lines in your changes missing coverage. Please review.

Project coverage is 72.11%. Comparing base (472685c) to head (16d7e46).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
FHEM/14_SD_WS.pm 82.92% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1271      +/-   ##
==========================================
- Coverage   72.44%   72.11%   -0.34%     
==========================================
  Files         138      139       +1     
  Lines       10192    10220      +28     
  Branches     1599     1602       +3     
==========================================
- Hits         7384     7370      -14     
- Misses       1478     1517      +39     
- Partials     1330     1333       +3     
Flag Coverage Δ
fhem 62.91% <82.92%> (-0.08%) ⬇️
modules 72.11% <82.92%> (-0.34%) ⬇️
perl 89.49% <ø> (-1.10%) ⬇️
unittests 72.11% <82.92%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sidey79 sidey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Negative Temperatur haben wir nicht in den Testdaten, daher kann er dein einen Codeabschnitt wohl nicht ausführen.

Woher weisst Du, wodurch die Temp negativ dargestellt wird?

@elektron-bbs
Copy link
Contributor Author

Negative Temperaturen konnte ich zwar lokal testen (#92 (comment)), habe aber keine rawmsg dazu.

@elektron-bbs elektron-bbs merged commit 87d5736 into master Sep 8, 2024
17 of 18 checks passed
@elektron-bbs elektron-bbs deleted the master_TFA_Joker branch November 1, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants