-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SD_WS_48 TFA JOKER Temperature transmitter 30.3212 #1271
Conversation
Decoding realized.
add testdata for temperature transmitter TFA 30.3212
…into master_TFA_Joker
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1271 +/- ##
==========================================
- Coverage 72.44% 72.11% -0.34%
==========================================
Files 138 139 +1
Lines 10192 10220 +28
Branches 1599 1602 +3
==========================================
- Hits 7384 7370 -14
- Misses 1478 1517 +39
- Partials 1330 1333 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Negative Temperatur haben wir nicht in den Testdaten, daher kann er dein einen Codeabschnitt wohl nicht ausführen.
Woher weisst Du, wodurch die Temp negativ dargestellt wird?
Negative Temperaturen konnte ich zwar lokal testen (#92 (comment)), habe aber keine rawmsg dazu. |
What is the current behavior?
(You can also link to an open issue here, if this describes the current behavior)
No decoding was implemented so far, see 'Joker' Funk-Thermometer TFA Dostmann #92
What is the new behavior (if this is a feature change)?
Decoding is now realized.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Other information: