prompt to install languageserver is not available#965
Merged
renkun-ken merged 10 commits intoREditorSupport:masterfrom Feb 6, 2022
Merged
prompt to install languageserver is not available#965renkun-ken merged 10 commits intoREditorSupport:masterfrom
renkun-ken merged 10 commits intoREditorSupport:masterfrom
Conversation
renkun-ken
reviewed
Feb 5, 2022
eitsupi
reviewed
Feb 5, 2022
Member
|
@shrektan I rewrite some code in this PR:
|
Contributor
Author
|
@renkun-ken Looks good to me. Much cleaner. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Fixes #754
Newbies may find it confusing when the R package
languageserveris not installed. This PR enables a prompt to instruct the user to installlanguageserverif missing.(We can use the added function to check other required R packages as well)
(I've also verified that it works on Windows)
How can I check this pull request?
remove.packages("languageserver")Screenshot