Skip to content

update the .gitignore file for R#949

Merged
renkun-ken merged 6 commits intoREditorSupport:masterfrom
eitsupi:update-r-gitignore
Jan 28, 2022
Merged

update the .gitignore file for R#949
renkun-ken merged 6 commits intoREditorSupport:masterfrom
eitsupi:update-r-gitignore

Conversation

@eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Jan 21, 2022

What problem did you solve?

Reflects the update of the original .gitignore file for R.
It also reflects the comments that existed in the original file.

https://github.com/github/gitignore

(If you do not have screenshot) How can I check this pull request?

Check the .gitignore file that is generated by executing the "R: Create gitignore" command from the command palette.

@eitsupi eitsupi force-pushed the update-r-gitignore branch from 8094839 to 04fa7c7 Compare January 21, 2022 15:05
@renkun-ken
Copy link
Member

Would it be easier to maintain if we just put the file at R/R.gitignore and just copy the file?

@eitsupi
Copy link
Contributor Author

eitsupi commented Jan 21, 2022

Would it be easier to maintain if we just put the file at R/R.gitignore and just copy the file?

That would be great.
In that case, I think GitHub Actions can detect the upstream updates and update that file semi-automatically by using https://github.com/peter-evans/create-pull-request.

@eitsupi
Copy link
Contributor Author

eitsupi commented Jan 21, 2022

I noticed that this command now silently overwrites the .gitignore file, so I changed it to ask the user if they want to overwrite it on the last commit.

@eitsupi
Copy link
Contributor Author

eitsupi commented Jan 21, 2022

I've isolated the R.gitignore file, but I'm not sure if this is the right way to do it. It does not seem to work on the extension development host.
-> fixed

Copy link
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renkun-ken renkun-ken merged commit 8b1cb58 into REditorSupport:master Jan 28, 2022
@eitsupi eitsupi deleted the update-r-gitignore branch January 28, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants