Skip to content

Make help preview async#1273

Merged
renkun-ken merged 1 commit intoREditorSupport:masterfrom
ManuelHentschel:asyncPreview
Dec 8, 2022
Merged

Make help preview async#1273
renkun-ken merged 1 commit intoREditorSupport:masterfrom
ManuelHentschel:asyncPreview

Conversation

@ManuelHentschel
Copy link
Member

Makes the generation of help page previews from .Rd files asynchronous to avoid blocking vscode, if the generation takes longer.

I don't know a reproducible example to illustrate this, but on slower machines this PR should eliminate one (possible) source of vscode delays.

Copy link
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renkun-ken renkun-ken merged commit 8d7d9ae into REditorSupport:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants