Merged
Conversation
Collaborator
ElianHugh
commented
Oct 24, 2022
ElianHugh
commented
- Add vsc.dev.args setting
- Add enum descriptions to r.source.focus
- Minor stylistic changes to item descriptions
- Add vsc.dev.args setting - Add enum descriptions to r.source.focus - Minor stylistic changes
renkun-ken
reviewed
Oct 24, 2022
R/session/vsc.R
Outdated
| vsc.object_timeout = session$objectTimeout, | ||
| vsc.globalenv = session$watchGlobalEnvironment, | ||
| vsc.plot = setting(session$viewers$viewColumn$plot, Disable = FALSE), | ||
| vsc.dev.args = c(width = plot$devArgs$width, height = plot$devArgs$height), |
Member
There was a problem hiding this comment.
The option is used as following:
dev_args <- getOption("vsc.dev.args")
do.call(png, c(list(filename = plot_file), dev_args))Maybe it makes more sense to just keep it as a list and not just limited to width and height.
renkun-ken
reviewed
Oct 24, 2022
renkun-ken
reviewed
Oct 24, 2022
| "default": 1200 | ||
| } | ||
| }, | ||
| "additionalProperties": false |
Member
There was a problem hiding this comment.
Maybe more arguments could be allowed here.
Collaborator
Author
There was a problem hiding this comment.
Ah, seeing how it leads to a call to png, that's a good point. If we remove the restriction, the settings UI will fallback to the "edit in JSON" dialog. I'm not sure if that's ideal? I think there's an argument to be made that if dots is required, people can use the R option. Alternatively, we could have '...' dots as an item for passing further args
Member
There was a problem hiding this comment.
I think this one is good enough. Let's revisit if somebody complains.
- Keep devArgs as a list - Width + height defaults set to 480 - Add some more options to devArgs Pending discussion on args + settings UI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.