Skip to content

Add Create .linr command#1112

Merged
renkun-ken merged 3 commits intoREditorSupport:masterfrom
eitsupi:add-lintr-file
Jul 4, 2022
Merged

Add Create .linr command#1112
renkun-ken merged 3 commits intoREditorSupport:masterfrom
eitsupi:add-lintr-file

Conversation

@eitsupi
Copy link
Contributor

@eitsupi eitsupi commented May 25, 2022

What problem did you solve?

Close #712

Add a simple command that simply calls the lintr::use_lintr function that will be added in lintr 3.0.0.

(If you have)Screenshot

(If you do not have screenshot) How can I check this pull request?

Select "Create .linr to the workspace" from the command palette, with the development version of lintr package installed.

@eitsupi eitsupi marked this pull request as ready for review June 16, 2022 12:38
Minor typo fix
@ElianHugh
Copy link
Collaborator

I think now that we are moving toward more file creation functions, after this is merged we should look at relocating the files to a dedicated folder

@eitsupi eitsupi requested a review from renkun-ken July 3, 2022 10:24
@renkun-ken
Copy link
Member

Currently, a .lintr is created silently and nothing happens when it is created.

Does it make sense to open the lintr file once it is created?

For example, we could capture the path of the created .lintr

normalizePath(lintr::use_lintr())

and open it in vscode when the background process is finished.

@eitsupi
Copy link
Contributor Author

eitsupi commented Jul 4, 2022

Does it make sense to open the lintr file once it is created?

I think it maybe a bit noisy.
The remote-containers.createDevContainerFile command that adds the devcontainer definition files to the project is the vscode command that I often use to add files, but this also does not open the file after it is added.

Copy link
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@renkun-ken
Copy link
Member

Does it make sense to open the lintr file once it is created?

I think it maybe a bit noisy. The remote-containers.createDevContainerFile command that adds the devcontainer definition files to the project is the vscode command that I often use to add files, but this also does not open the file after it is added.

OK sounds reasonable. Let's keep it silent for now.

@renkun-ken renkun-ken merged commit 1f692eb into REditorSupport:master Jul 4, 2022
@eitsupi eitsupi deleted the add-lintr-file branch July 4, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "Create .lintr" command

3 participants