Skip to content

Add r.session.data.pageSize#1068

Merged
renkun-ken merged 2 commits intoREditorSupport:masterfrom
renkun-ken:page-size
Apr 9, 2022
Merged

Add r.session.data.pageSize#1068
renkun-ken merged 2 commits intoREditorSupport:masterfrom
renkun-ken:page-size

Conversation

@renkun-ken
Copy link
Member

What problem did you solve?

Closes #1067

(If you do not have screenshot) How can I check this pull request?

Adjust r.session.data.pageSize to 100, 500 and 0 and View(data.frame(id = 1:1000)) and see if the setting applies properly.

@eitsupi
Copy link
Contributor

eitsupi commented Apr 9, 2022

Just a question: what good does it do to reduce the page size? (display performance?)
My understanding is that all data is read regardless of page size, so the initial value for page size seems like it should be larger.

@renkun-ken
Copy link
Member Author

renkun-ken commented Apr 9, 2022

I think it only affects the rendering performance, as larger page size means more objects in the WebView. Also, if the page size is too large, the scrolling will be harder to locate certain rows.

Here, the default value 100 comes from ag-grid. Maybe we could use 500.

@renkun-ken renkun-ken merged commit 02cd835 into REditorSupport:master Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a setting for number of rows per page in the data viewer

2 participants