Skip to content

Hide smart knit env values to prevent accidental deletion #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renkun-ken merged 2 commits into from
Apr 4, 2022
Merged

Hide smart knit env values to prevent accidental deletion #1060

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c51ee0
Hide env values in a namespace to prevent removal
ElianHugh Apr 4, 2022
69ae63f
Newline
renkun-ken Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions R/rmarkdown/knit.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,30 @@ if (!requireNamespace("rmarkdown", quietly = TRUE)) {
}

# get values from extension-set env values
# Hiding values is necessary to prevent their accidental removal
# See: https://github.com/REditorSupport/vscode-R/issues/860
attach(
local({
.vsc.knit_dir <- Sys.getenv("VSCR_KNIT_DIR")
.vsc.knit_lim <- Sys.getenv("VSCR_LIM")
.vsc.knit_command <- Sys.getenv("VSCR_KNIT_COMMAND")
environment()
}),
name = "tools:vscode",
warn.conflicts = FALSE
)

knit_dir <- Sys.getenv("VSCR_KNIT_DIR")
lim <- Sys.getenv("VSCR_LIM")
knit_command <- Sys.getenv("VSCR_KNIT_COMMAND")

# set the knitr chunk eval directory
# mainly affects source calls
if (nzchar(knit_dir)) {
knitr::opts_knit[["set"]](root.dir = knit_dir)
if (nzchar(.vsc.knit_dir)) {
knitr::opts_knit[["set"]](root.dir = .vsc.knit_dir)
}

# render and get file output location for use in extension
cat(
lim,
eval(parse(text = knit_command)),
lim,
.vsc.knit_lim,
eval(parse(text = .vsc.knit_command)),
.vsc.knit_lim,
sep = ""
)