Use bindingIsActive

[renkun-ken]

What problem did you solve?

Related: #1030

This PR uses bindingIsActive(sym, env) to check if a symbol is active binding. It is a walk around of rlang::env_binding_are_active when base already does it.

(If you have)Screenshot

(If you do not have screenshot) How can I check this pull request?

makeActiveBinding("x", function() {
  cat("x\n")
  runif(1)
}, globalenv())

Run other commands and see if the workspace viewer correctly shows x as an active binding.

env <- local({
  makeActiveBinding("x", function() {
    cat("x\n")
    runif(1)
  }, environment())
  environment()
})
View(env)

[MilesMcBain]

Does this still have an issue since rlang::env_binding_are_lazy(env, all_names) will evaluate the active bindings also?

[renkun-ken]

Yes, rlang::env_binding_are_lazy(env, all_names) still will evaluate active bindings. So this PR does not resolve the problem but only replaces rlang function with base when possible.