add R package build task - build source and build binary like RStudio#1029
Merged
renkun-ken merged 4 commits intoREditorSupport:masterfrom Mar 10, 2022
Merged
add R package build task - build source and build binary like RStudio#1029renkun-ken merged 4 commits intoREditorSupport:masterfrom
renkun-ken merged 4 commits intoREditorSupport:masterfrom
Conversation
renkun-ken
reviewed
Mar 10, 2022
package.json
Outdated
| }, | ||
| { | ||
| "title": "Build", | ||
| "title": "Build Source", |
Member
There was a problem hiding this comment.
What about we keep "Build" (to not break existing keybindings) and adds "Build Binary"?
Author
There was a problem hiding this comment.
That's really fine, and this will cause less errors for users already using this.
renkun-ken
reviewed
Mar 10, 2022
package.json
Outdated
| { | ||
| "title": "Build Binary", | ||
| "category": "R Package", | ||
| "command": "r.buildbinary" |
Member
There was a problem hiding this comment.
Better use r.buildBinary here for consistency.
renkun-ken
reviewed
Mar 10, 2022
src/extension.ts
Outdated
|
|
||
| // environment independent commands. this is a workaround for using the Tasks API: https://github.com/microsoft/vscode/issues/40758 | ||
| 'r.build': () => vscode.commands.executeCommand('workbench.action.tasks.runTask', 'R: Build'), | ||
| 'r.buildsource': () => vscode.commands.executeCommand('workbench.action.tasks.runTask', 'R: BuildSource'), |
Member
There was a problem hiding this comment.
Is it better to use R: Build and R: Build Binary as the task names?
Author
|
Thanks for your help and suggestions, @renkun-ken, I have rename this conflicted names and keep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RStudio provides two build task with
devtools::build()anddevtools::build(binary = TRUE, args = c('--preclean')), This PR providesr.buildbinarycommand to rundevtools::build(binary = TRUE, args = c('--preclean'))as task and rename originalr.buildtor.buildsource.