Using "recently used" tasks launches the wrong task

[gowerc]

This might be an issue with my local setup as I've been messing around with task settings a lot but it would help if someone else could test if they are getting the same issue or not.

Essentially if I run the "R: document" task and then re-run it by selecting the "recently used" tasks it launches the wrong task (the build task instead). I've added a video below to highlight the issue:

simplescreenrecorder-2022-02-13_12.34.15.mp4

If the issue isn't repeatable feel free to close as it probably means I've just borked my local config :)

[renkun-ken]

I could reproduce this. Not sure what caused it yet. I tested npm watch and npm compile tasks in this project, but it works as expected.

[renkun-ken]

I tried moving the Document task before the Build task, and the "recently used" task will execute Document task instead. Looks like the recently used task always executes the first task provided.

Looks like there is something we misuse in providing tasks?

[renkun-ken]

When I put .vscode/tasks.json with the following content:

{
	"version": "2.0.0",
	"tasks": [
		{
			"type": "R",
			"label": "R: Build",
			"problemMatcher": []
		},
		{
			"type": "R",
			"label": "R: Document",
			"problemMatcher": []
		}
	]
}

then the R tasks will become all identical

but choosing each will still work properly.

[renkun-ken]

And the "recently used" item actually comes from task.json:

{
	"version": "2.0.0",
	"tasks": [
		{
			"type": "R",
			"label": "Test1"
		}
	]
}

and the recently used item becomes

Choosing this item will call resolveTask(task: vscode.Task) but no matter what Task this function returns, the build task (first item in tasks) will be executed.

[renkun-ken]

From the TaskProvider documentation, it says

resolveTask requires that the same definition object be used.

I tried the following code:

public resolveTask(task: vscode.Task): vscode.Task {
        return new vscode.Task(
            task.definition,
            vscode.TaskScope.Workspace,
            'Install',
            'R',
            new vscode.ShellExecution(
                'Rscript',
                [
                    '-e',
                    {
                        value: 'devtools::install()',
                        quoting: vscode.ShellQuoting.Strong
                    }
                ]
            )
        );
    }

where the returned Task has to use the intput task.definition and it works. Looks like we shoud properly implement resolveTask to make it work with user customized R tasks in tasks.json.