Sync updates from AlphaHENG contrib #4
Conversation
Major changes: - Benchmark scripts for profiling and throughput testing - Gated MLP Metal shader fusion implementation - Fast-path integration tests - Library loading test utilities - Buffer pool, encoder cache, MoE manager improvements - Trellis module enhancements (attention, dispatch, linear layers) - Various kernel optimizations and bug fixes
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6877bd7c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| paths: | ||
| - 'src/*.metal' | ||
| pull_request: | ||
| paths: | ||
| - 'src/*.metal' |
There was a problem hiding this comment.
This workflow only triggers on src/*.metal, so shader changes in nested directories (e.g., src/fusion/*.metal, src/vision/*.metal, etc.) won't run the compile/audit checks at all. That means newly added or modified shaders outside the root src folder can land without being compiled or audited, letting breakage slip into main. Consider expanding the path filter (and the compile loop) to cover all Metal shaders under src/**.metal.
Useful? React with 👍 / 👎.
| - name: Run Kernel Audit | ||
| run: | | ||
| output=$(uv run python audit_kernels.py) |
There was a problem hiding this comment.
uv run python audit_kernels.py runs from the repo root, but the only audit_kernels.py in this tree lives under developer_tests/ (verified with rg --files -g 'audit_kernels.py'). As written, the step will fail with “No such file or directory” whenever the workflow runs. Point the command at the correct path (e.g., developer_tests/audit_kernels.py) or cd before invoking it.
Useful? React with 👍 / 👎.
1 participant
Summary
Syncs all changes from the AlphaHENG/contrib/metal_marlin folder to this repository.
Major Changes