Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update audio engine #366
base: master
Are you sure you want to change the base?
Update audio engine #366
Changes from 18 commits
aea0e26
f773798
f2d84e4
5979f79
4306e72
cd5e440
7ed92f6
c3e0385
1ab3fbe
ce3042c
d3a0348
dac612d
e10c5aa
6651301
69574b0
e820843
54c13a3
3cbb8d9
c671961
c4b4588
e0f423a
f0691c0
d5f9367
2220b89
0285540
84b22ce
e5e1124
7ec8c7d
f93d45c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it should be doable with unique_ptr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to do it with a
unique_ptr
because OpenGLAudioEngine keeps reference of the sounds that have been createdThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the destruction order of
Sound
andOpenGLAudioEngine
unspecified?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering that
OpenGLAudioEngine
is basically guaranteed to never be destroyed (it should be destroyed when the application closes),Sound
s are always going to die before the engine. The issue is that theEngine
gives outSound
s to its users, and these objects must stay alive even if they go out of scope, otherwise the sounds would stop playing. So theEngine
keeps reference of all created sounds and destroys them when they are not tracked anymore by anyone else and they are not playing