Skip to content

Conversation

@ddeschepper
Copy link
Contributor

Summary of changes

Solves #3105 by storing the namespace manager of the graph that is to be serialized temporarily and reapplying it to the graph that is actually serialized by the implementation of the longturtle serializer.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • If the change has a potential impact on users of this project:
    • Added or updated tests that fail without the change.
    • Updated relevant documentation to avoid inaccuracies.
    • Considered adding additional documentation.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@edmondchuc
Copy link
Contributor

Thank you for this! I had a local PR that I wrote up on the weekend but you beat me to it. :)

This partially resolves #3062 but just noting here the prefix declaration for rdf is still not preserved when the value rdf:type is used in the object position of a triple.

@ddeschepper
Copy link
Contributor Author

@edmondchuc is there anything I can do to help this get merged? I see some failing checks, but I'm unsure what causes them.

@edmondchuc edmondchuc changed the base branch from main to 7.x May 7, 2025 04:45
@edmondchuc edmondchuc changed the base branch from 7.x to main May 7, 2025 04:45
@edmondchuc
Copy link
Contributor

FYI just realised this PR was based off of the main branch. I've created a separate PR to target the v7 branch so we can get it released.

@nicholascar nicholascar merged commit 5e88541 into RDFLib:main May 31, 2025
8 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants