Skip to content

Conversation

@aucampia
Copy link
Member

@aucampia aucampia commented Apr 9, 2023

Summary of changes

XMLNS was seen as unused in rdflib/__init__.py but this change adds it to __all__ in that module so that it is not unused.

This change also removes actual unused imports in
rdflib/namespace/__init__.py.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

`XMLNS` was seen as unused in `rdflib/__init__.py` but this change adds it to
`__all__` in that module so that it is not unused.

This change also removes actual unused imports in
`rdflib/namespace/__init__.py`.
@coveralls
Copy link

Coverage Status

Coverage: 90.831% (-0.0009%) from 90.832% when pulling 5ee4b99 on aucampia:iwana-20230409T1843-remove_unused into 4940798 on RDFLib:main.

@aucampia aucampia marked this pull request as ready for review April 9, 2023 17:06
@aucampia aucampia requested a review from a team April 9, 2023 17:06
@aucampia aucampia added review wanted This indicates that the PR is ready for review ready to merge The PR will be merged soon if no further feedback is provided. refactor This issue concerns a change that neither fixes a bug nor adds a feature. labels Apr 9, 2023
@aucampia
Copy link
Member Author

Merging without review, as this does not change runtime behaviour.

@aucampia aucampia merged commit b2f3987 into RDFLib:main Apr 10, 2023
@aucampia aucampia deleted the iwana-20230409T1843-remove_unused branch June 8, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge The PR will be merged soon if no further feedback is provided. refactor This issue concerns a change that neither fixes a bug nor adds a feature. review wanted This indicates that the PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants