Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Mar 22, 2023

Update CONTRIBUTORS from commit history, add .mailmap to fix early mis-attributed contributions

Checklist

  • Checked that there aren't other open pull requests for the same change.
  • Added tests for any changes that have a runtime impact.
  • Checked that all tests and type checking passes.
  • For changes that have a potential impact on users of this project:
    • Updated relevant documentation to avoid inaccuracies.
    • Considered adding additional documentation.
    • Considered adding an example in ./examples for new features.
    • Considered updating our changelog (CHANGELOG.md).
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@ghost ghost self-requested a review March 22, 2023 11:53
@coveralls
Copy link

Coverage Status

Coverage: 90.794%. Remained the same when pulling 8ceb557 on gjhiggins:update-contrib into cfe6e37 on RDFLib:main.

Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, must have been some effort, but I think it is very valuable to have an accurate list and mailmap.

@aucampia
Copy link
Member

I will merge tomorrow.

@aucampia aucampia added review wanted This indicates that the PR is ready for review ready to merge The PR will be merged soon if no further feedback is provided. labels Mar 22, 2023
@white-gecko white-gecko self-requested a review March 23, 2023 08:58
@aucampia aucampia merged commit 1ab4fc0 into RDFLib:main Mar 23, 2023
@ghost ghost deleted the update-contrib branch March 23, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge The PR will be merged soon if no further feedback is provided. review wanted This indicates that the PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants