-
Notifications
You must be signed in to change notification settings - Fork 581
Open
Labels
LSP-violationLiskov substitution principle violationLiskov substitution principle violationbreaking changeThis involves or proposes breaking RDFLib's public API.This involves or proposes breaking RDFLib's public API.
Description
SPARQLStore inherits from SPARQLConnector and rdflib.store.Store, however, these two classes have the same methods with different signatures:
| class SPARQLStore(SPARQLConnector, Store): |
Methods in rdflib.store.Store:
Line 334 in 0856ac8
| def query(self, query, initNs, initBindings, queryGraph, **kwargs): # noqa: N803 |
Line 350 in 0856ac8
| def update(self, update, initNs, initBindings, queryGraph, **kwargs): # noqa: N803 |
Methods in SPARQLConnector:
| def query(self, query, default_graph: str = None, named_graph: str = None): |
rdflib/rdflib/plugins/stores/sparqlconnector.py
Lines 144 to 149 in 0856ac8
| def update( | |
| self, | |
| query, | |
| default_graph: Optional[str] = None, | |
| named_graph: Optional[str] = None, | |
| ): |
This situation should be resolved to avoid LSP violations.
Metadata
Metadata
Assignees
Labels
LSP-violationLiskov substitution principle violationLiskov substitution principle violationbreaking changeThis involves or proposes breaking RDFLib's public API.This involves or proposes breaking RDFLib's public API.